# HG changeset patch # User Michiel Broek # Date 1424019981 -3600 # Node ID 249e7d506069a184d5adadaf7b9dcb24ff9cab1d # Parent 97602274eb5851a8397beda96a04b74ce34701f2 PID old error was not set to the previous value but was always zero. diff -r 97602274eb58 -r 249e7d506069 thermferm/thermferm.c --- a/thermferm/thermferm.c Sat Feb 07 23:12:55 2015 +0100 +++ b/thermferm/thermferm.c Sun Feb 15 18:06:21 2015 +0100 @@ -1320,7 +1320,7 @@ sp = unit->prof_target; } - unit->PID_err_old = err; +// unit->PID_err_old = err; err = sp - pv; if (err < unit->idle_rangeH && err > unit->idle_rangeL) { err = 0; @@ -1335,6 +1335,7 @@ unit->PID_I_err = 10.0; P_err = err; D_err = err - unit->PID_err_old; + unit->PID_err_old = err; /* * A postive value means heating, a negative value cooling.