Added remarks about beerxml design flaws.

Tue, 21 Jun 2022 16:16:43 +0200

author
Michiel Broek <mbroek@mbse.eu>
date
Tue, 21 Jun 2022 16:16:43 +0200
changeset 304
aa8d421bfc24
parent 303
6efe0ea2e663
child 305
35ce719998e1

Added remarks about beerxml design flaws.

src/EditProductExport.cpp file | annotate | diff | comparison | revisions
src/EditRecipeExport.cpp file | annotate | diff | comparison | revisions
--- a/src/EditProductExport.cpp	Tue Jun 21 09:26:25 2022 +0200
+++ b/src/EditProductExport.cpp	Tue Jun 21 16:16:43 2022 +0200
@@ -28,7 +28,10 @@
     /*                                                    "Leaf Wet", "Cryo", "Extract" */
     /*  We use more hop forms then beerxml knows about, so we send known names */
     /*  instead of what we internally use. */
-    const QStringList hop_use({ "Mash", "First wort", "Boil", "Aroma", "Whirlpool", "Dry hop", "Dry hop" });	// tetra == dry-hop :(
+
+    /*  Note: Whirlpool hop is Aroma + time. Hop at flame-off is Aroma with time = 0. BeerXML is really stupid designed. */
+    /*                                                flame-off vv        vv whirlpool hop */
+    const QStringList hop_use({ "Mash", "First wort", "Boil", "Aroma", "Aroma", "Dry hop", "Dry hop" });	// tetra == dry-hop :(
     const QStringList yeast_type({ "Lager", "Ale", "Wheat", "Wine", "Champagne", "Other", "Other", "Other", "Other", "Other" });
     const QStringList yeast_form({ "Liquid", "Dry", "Slant", "Culture", "Frozen", "Bottle", "Dry" });
 
--- a/src/EditRecipeExport.cpp	Tue Jun 21 09:26:25 2022 +0200
+++ b/src/EditRecipeExport.cpp	Tue Jun 21 16:16:43 2022 +0200
@@ -26,7 +26,10 @@
     /*                                                    "Leaf Wet", "Cryo", "Extract" */
     /*  We use more hop forms then beerxml knows about, so we send known names */
     /*  instead of what we internally use. */
-    const QStringList hop_use({ "Mash", "First wort", "Boil", "Aroma", "Whirlpool", "Dry hop", "Dry hop" });
+
+    /*  Note: Whirlpool hop is Aroma + time. Hop at flame-off is Aroma with time = 0. BeerXML is really stupid designed. */
+    /*                                                flame-off vv        vv whirlpool hop */
+    const QStringList hop_use({ "Mash", "First wort", "Boil", "Aroma", "Aroma", "Dry hop", "Dry hop" });
     const QStringList yeast_type({ "Lager", "Ale", "Wheat", "Wine", "Champagne", "Other", "Other", "Other", "Other", "Other" });
     const QStringList yeast_form({ "Liquid", "Dry", "Slant", "Culture", "Frozen", "Bottle", "Dry" });
 

mercurial